Porting Dynamic_Update_Slice operator from TFLite #3246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync changes
ddavis-2015
reviewed
Oct 28, 2025
veblush
reviewed
Nov 3, 2025
| output_data); | ||
| } | ||
|
|
||
| TF_LITE_MICRO_TEST(DynamicUpdateSliceOpTestBoundaryTest) { |
There was a problem hiding this comment.
What's the purpose of this test? How is this different from DynamicUpdateSliceOpTestSimpleFloat?
There was a problem hiding this comment.
It is same as DynamicUpdateSliceOpTestSimpleFloat except the indices. Here in this test indices used are corner case
Comment on lines
55
to
57
| if (current_dim == max_dims) { | ||
| return kTfLiteOk; | ||
| } |
There was a problem hiding this comment.
I guess this is unreachable?
There was a problem hiding this comment.
It will, because it will be called by increasing current_dim count in recursively
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Dynamic_Update_Slice operator changes.
BUG=fixes #3217